All ten milestones are closed. Every pull request had its review, but every review saw only a part: one milestone, often just a piece of it. What a part doesn’t show is the whole. Are the error codes named the same everywhere? Does Program.cs still read like a place that puts things together, or like a collection of afterthoughts? Does a rule now stand twice, once in the core and once in a page? Can someone who didn’t build the Kladde find their way around in it?

This lesson answers these questions in three steps. First you check yourself what can be checked automatically. Then someone with fresh eyes reads the whole Kladde (who, in a moment), and you answer every comment. Finally you bring the README and the decisions into a form that works for strangers, because that is exactly who will see the Kladde in the next lesson.

Pull request Branch Brings Where in this lesson
1 chore/final-checks the script for the pre-check, the test for the boundary of the core, the fixes “The pre-check” and exercise 1
– review/k2-start the pull request for the review over everything; it is never merged “One review over everything”
2 and more fix/review-… one comment each, or a group that belongs together exercise 2
last docs/readme-and-decisions README and docs/decisions.md in their final form exercise 3

Where the Kladde stands

After milestone 10, the solutions have this:

  • All tests run in every pull request; scripts/Find-MissingTests.ps1 checks the evidence of the issues (milestone 9).
  • docs/ contains definition-of-done.md, review-checklist.md, accessibility.md, threat-list.md, data-model.md, operations.md and decisions.md. In decisions.md the decisions stand the way they came about in the lessons: one after another, in different forms.
  • The README has a section “Operations” from milestone 10. The rest has grown as it was needed.

If your files, classes or folders are named differently, keep your names and carry the steps over.