So far you have built and checked your own Kladde. In this lesson you check the Kladde of a person from your circle (a colleague, a study group, the public learning community), and that person checks yours. If you find nobody, check your own Kladde after a break with the same questions, as if it were someone else's. An architecture review is not a grade and not a code review on a larger scale. It asks whether a system reaches its own goals and whether its decisions hold up: Does the isolation deliver what the quality scenario promises? Can an office really be brought back? Would a new colleague understand from the documentation how a quote runs through the system?

The review is part of the final project. For the architecture review with a checklist (4.9.7), the review you wrote and your answers to the review of your work are ready. Both count for your own learning success: how precisely you read a foreign architecture, and how you deal with criticism of your own.

How the review runs

Two participants check each other, or three in a circle (A checks B, B checks C, C checks A); in a circle there is no trading of favors in the pattern “you go easy on me, I go easy on you”. The process has four parts:

Part Who Duration Result
1. The 30-minute test You read the foreign docs/, without code 30 minutes reading, 5 minutes explaining first findings on the documentation
2. Checking You read code, run tests, check proofs about 75 minutes notes with evidence
3. Writing and discussing You write the review (about 30 minutes), then 30 minutes of conversation about 60 minutes docs/reviews/review-1.md in the foreign repository
4. Answering the person reviewed until the checklist in 4.9.7 every row answered

Three rules apply to all parts:

  • The work is checked, not the person. “The worker has more rights than the permissions table”, not “you forgot the rights”.
  • Questions before judgments. What looks like a mistake is often a decision you do not know about. Look for the ADR; if there is none, that is exactly the finding.
  • No finding without evidence. A file with a line, a test, a measurement, a link. “The isolation seems incomplete” is a feeling; “GET /api/tenders/{id}/documents is listed as an exemption without a reason in IsolationTests” is a finding.